-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModuleNotFoundError: No module named 'hatchling.dep' with hatchling 1.26.0 #1793
Comments
Yes. Me too for |
+1 |
1 similar comment
+1 |
Same here! |
Same with airflow. Pinning to hatchling 1.25.0 fixes the issue |
Unfortunately in my case I don't control the dependency on hatchlings so I can't pin it directly. Is there something akin to a global constraints file for pip? Ideally, 1.26.0 would be yanked or a patch for hatch released asap. |
The hatch-v1.13.0 tag still contains the following code: Lines 37 to 40 in 4e3c515
|
#1582 / adba003 removed the above code and predates 28bfe35. Yet, it didn't make it into hatch-v1.13.0. What happened? |
The hatch-v1.13.x branch was forked from the master branch too early as far as I can see, and misses most recent changes that are necessary to hatchling 1.26.0, including #1582 / adba003. I think the hatch-v1.13.0 tag should have been applied to the master branch on 28bfe35, instead it has been applied to the spurious hatch-v1.13.x branch on 4e3c515. The solution is indeed to:
|
Sorry about that everybody!
I have a branch for that minor release because there was a bunch of stuff on master that was not yet ready to be released and it was important to ship support for Python 3.13. |
Thanks for a quick fix @ofek . How about yanking 1.26.0 ? I think it's generally broken, so might be good to yank it |
It's broken in relation to Hatch only, no? |
Yes. That's what we saw - it broke whe we installed hatch, but our packages seemeed to be build correctly. So yes - there is no "strong" need to yank it, but I guess it's no harm either. |
True, yanked! https://pypi.org/project/hatchling/1.26.0/ |
This version, unlike `hatch` 1.9.3, has an upper limit on the version of the `hatchling` dependency, which should prevent problems like this one: pypa/hatch#1793 when the new release of `hatchling` (1.26.0) was automatically picked up by `hatch` 1.9.3 and broke stuff. Change-Id: I4238087b80175e5ae732d44f95274bcf3ea2fdef Reviewed-on: https://gerrit.franz.com:9080/c/agraph-python/+/26469 Reviewed-by: Tianyu Gu <gty@franz.com> Tested-by: John Foderaro <jkf@franz.com> Reviewed-by: John Foderaro <jkf@franz.com> Ptest: John Foderaro <jkf@franz.com>
With the just-released 1.26.0, I'm getting the following error when using 'hatch run'
The text was updated successfully, but these errors were encountered: