Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apache Airflow to users of Hatch #1209

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Conversation

potiuk
Copy link
Contributor

@potiuk potiuk commented Jan 13, 2024

No description provided.

docs/community/users.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't know how I missed that one.

@potiuk
Copy link
Contributor Author

potiuk commented Jan 13, 2024

Thank you! I don't know how I missed that one.

Well. You have not ... We just switched to Hatch last week :) with this GIANT PR of mine apache/airflow#36537.

We had some REALLY complex setup and monorepo (I also commented in #233 (comment)) - it now works nicely with the variant of monorepo we currently have. This is done via some smart pre-commit integration (that automatically generates part of our pyproject.toml), custom description of our monorepo provider packages (almost 90 of those), namespace packages and on-the-flight manipulating the "standard" wheel dependencies. We dynamically replace the editable dependencies of other monorepo packages we have in pyproject.toml with the actual depenendencies to the packages themselves - I described the gist of it in #588 (comment).

I am actuallly VERY happy with what Hatch and Hatchling (both) give us in Airflow.

But I would love to cooperate in the future and help to figure out a more "proper" monorepo support - maybe involving some way of merging pyproject.toml and editable paths between the monoreps (as I described in #233 (comment)) - And I came to think that maybe it will need some PEP to describe it before Hatch implements it.

I'd love to hear your thoughts.

Airflow might be great testing ground for it (especially now where Hatch/Hatchling are so nicely integrated).

@potiuk
Copy link
Contributor Author

potiuk commented Jan 21, 2024

Shall we merge :) ?

@ofek
Copy link
Collaborator

ofek commented Jan 21, 2024

Yes this was on my schedule today, sorry for the wait! The workspaces feature I'm planning will definitely have to satisfy your use case in order to be merged and I will work closely with you when I have a PoC.

@ofek ofek merged commit d167faa into pypa:master Jan 21, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 21, 2024
Co-authored-by: Ofek Lev <ofekmeister@gmail.com> d167faa
@potiuk
Copy link
Contributor Author

potiuk commented Jan 21, 2024

Yes this was on my schedule today, sorry for the wait! The workspaces feature I'm planning will definitely have to satisfy your use case in order to be merged and I will work closely with you when I have a PoC.

Looking forward to it :)

github-actions bot pushed a commit to juftin/hatch that referenced this pull request Jan 31, 2024
Co-authored-by: Ofek Lev <ofekmeister@gmail.com> d167faa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants