Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce image size #206

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Reduce image size #206

merged 2 commits into from
Jul 4, 2018

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented May 26, 2018

1st commit fixes python test removal: around 100MB saved
2nd commit makes x86_64 image based on centos:5 rather than centos:5.11: around 150MB saved

@trishankatdatadog
Copy link
Member

@mayeut Could you please explain the difference between the two tags?

@mayeut
Copy link
Member Author

mayeut commented Jun 1, 2018 •
edited
Loading

@trishankatdatadog,

centos:5.11 Stock image, identical to what you'd get from a fresh install using the 5.11 ISO
centos:5 base image has been built one year after the centos:5.11 image and thus already includes some package upgrades.
https://github.com/CentOS/sig-cloud-instance-images/tree/CentOS-5/docker
https://github.com/CentOS/sig-cloud-instance-images/tree/CentOS-5.11/docker

@trishankatdatadog
Copy link
Member

Got it, thanks @mayeut! As long as we always update the Centos within whenever we build, I think this is fine.

@mayeut
Copy link
Member Author

mayeut commented Jun 17, 2018

Rebased on up-to-date master which now includes python 3.7

quay.io/pypa/manylinux1_x86_64   pr       1aee74baba30    18 hours ago    881MB
quay.io/pypa/manylinux1_x86_64   latest   017377d5bcc4    37 hours ago    1.16GB

@trishankatdatadog, CentOS is still being updated on build. You can also find the list of installed packages along with their version in the build log. It's the exact same one with or without the PR.

@trishankatdatadog
Copy link
Member

LGTM

@ehashman ehashman merged commit a0d46fa into pypa:master Jul 4, 2018
dolang added a commit to dolang/manylinux that referenced this pull request Jul 4, 2018
@dolang
Merge a0d46fa; mirror base image change :6.9 -> :6
0a31334 
Like with CentOS 5 there's a CentOS 6 Docker image which is more up to
date (tag :6) than the latest release (tag :6.9).
See: pypa#206
@dolang dolang mentioned this pull request Jul 4, 2018
Closed
@mayeut mayeut deleted the shrink branch July 5, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayeut @trishankatdatadog @ehashman