-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.8.0a2 #273
Add Python 3.8.0a2 #273
Conversation
Edit: Updating |
@njsmith @matthew-brett This is ready for review and integration. Cc: @thewtex |
@jcfr Yeah, I was about to suggest updating CPython pubkeys. I'll manually review the keys ASAP. Thanks! |
That would be stellar 🌟 (And getting this integrated soon would allow us to move forward with updating dockcross without having to publish built image somewhere else. 😄 ) As hinted here, I grabbed them from https://www.python.org/static/files/pubkeys.txt. |
LGTM: ~/pypa/manylinux$ shasum -a 256 docker/build_scripts/cpython-pubkeys.txt
cc93a70d54978806c307c4a6727a68660cab6532a6e620a58dd63ffb35f92a29 docker/build_scripts/cpython-pubkeys.txt
~/pypa/manylinux$ curl -fSsLO https://www.python.org/static/files/pubkeys.txt
~/pypa/manylinux$ shasum -a 256 pubkeys.txt
a619effbd71693068e75f31156b464155b76580ad1fd7bc76a75523f36e9f2d6 pubkeys.txt
~/pypa/manylinux$ diff pubkeys.txt docker/build_scripts/cpython-pubkeys.txt
11542a11543
>
~/pypa/manylinux$ |
Thanks @trishankatdatadog for the helping out so quickly 🙏 |
Uhhh... 3.8's ABI isn't set yet. It's not actually possible to make working manylinux wheels for it, because the ABI will change between now and the final release. What's the purpose of having it in the image? I feel like it's inevitable this will lead to broken wheels on PyPI... |
From a quick skim of linked issues, I didn't see any discussion of why this is useful, and lots of discussion of wanting to make 3.8 wheels. Therefore I think we need to revert this ASAP, to protect people from themselves... |
Having 3.8 available is useful to setup testing and be ready for 3.8 actual release.
Sounds good. Waiting 3.8 is released, we will upload the available image having Python 3.8 support on dockerhub so that we can have it in dockcross. Our plan is to start publishing wheel for Python 3.8 .. then when the stable release is out we will re-release and add |
You can do whatever you like with your own packages, no skin off my nose :-). You should be aware though that there are literally zero ABI compatibility guarantees for 3.8 until it's released. They might change the ABI every day between now and October, and based on past experience, probably will change it several times at least. So a single image probably isn't going to get you to the release. |
Considering that Python 3.8 is alpha, that makes sense. For now, we will only publish wheels for
Indeed, we plan on updating the images each time a new alpha/beta/rc release of Python 3.8 is out. |
@njsmith @trishankatdatadog My apology for causing so much trouble. Here is the PR reverting #274 Cc: @thewtex |
This commit updates the version of manylinux base images to use custom flavor having Python 3.8. See https://github.com/scikit-build/manylinux#available-branches Python 3.8.0a2 was initially added to upstream manylinux after integrating pypa/manylinux#273. But considering that Python 3.8 is still an alpha release and that (1) the associated ABI is not yet stable and (2) incompatibilities are expected between wheels generated for alpha/beta/rc and final version of python 3.8.0, the manylinux maintainers decided to revert the update.
No worries. Thanks for understanding!
If you're just using a wheel as a container to ship a standalone executable, that doesn't actually use the Python C API, then there's an even better option: you can mark your wheels as
This way you only have to ship one wheel per platform. |
Revert "Merge pull request #273 from jcfr/add-cpython-3.8"
No description provided.