-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manylinux2014 images #348
manylinux2014 images #348
Conversation
507b7c5
to
c55f024
Compare
Can 'make' be called with multiple jobs? Would make build faster. |
Build on aarch64 fails:
Sure, it is manylinux2010 not compatible but only because this architecture did not existed at that time. |
So, how it will be processed? I am waiting for it to happen and then will discuss with several projects to get them to publish wheel files for AArch64 architecture. It will allow me to cut build times from 45 minutes to seconds... |
2e6fff6
to
79955a0
Compare
Travis CI got aarch64 support. There will be more projects ready to use manylinux2014 image once it get published. |
0de2594
to
79955a0
Compare
is it still WIP? |
@auvipy, yes still a work in progress. Needs at least an auditwheel update (not 2.1.1), README update |
9fb92f6
to
8049f83
Compare
Can I use this docker image to upload wheel tagged with 2014 to pypi.org ? |
dcdee0f
to
671e936
Compare
If possible, how about adding i686 to manylinux2014 docker images? It's one of architectures listed in manylinux2014 policy and there is a base CentOS 7 docker image. |
@veblush, I can't get a recent toolchain on i686, the one you found doesn't exist for centos 7. RHEL provides this for RHEL7 but not centos. |
2079382
to
3d430c5
Compare
Is there any todo list before it will be considered done? |
@mayeut Thank you for the detailed background! Sorry to know i686 doesn't get enough attention from Redhat and community. |
@veblush Red Hat decided to stop supporting i686 when RHEL7 development started. There is no new server class hardware with this architecture and users of "legacy" ones were supported with RHEL6. There is minimal support for i686 just to keep 32-bit applications running on 64-bit hardware. In CentOS 7 32-bit x86 is supported as one of "alternative" architectures - check http://mirror.centos.org/altarch/7/ for what is provided. And even there is looks like abandoned architecture. |
8c02f21
to
5344833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
23:24 - will look at problem tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more
5344833
to
96f202d
Compare
f26511d
to
87a2c5a
Compare
@hrw, thanks for all your reviews. While the build passes locally, there's an issue with travis-ci (seems docker related) that I can't explain so I'm going to try a few things... |
I work on aarch64 for 7+ years now so I am trying to help wherever I can.
No idea why it fails. |
Seems to be an issue on travis-ci side: https://travis-ci.community/t/docker-container-download-fails/5674 |
87a2c5a
to
08e534d
Compare
d03c44e
to
08e534d
Compare
@mayeut Thanks for all your work here. It looks like the Travis issues are resolved, and that this is blocked on a 3.0.0 release of auditwheel (pypa/auditwheel#205), correct? |
Correct. There's still one PR opened in auditwheel that needs review and be merged. |
And then will be time to go through all python projects and asking them to make more wheels. |
aeabd30
to
5880290
Compare
5880290
to
c90bda2
Compare
c90bda2
to
3206394
Compare
1st attempt at a manylinux2014 image
main differences with the 2010 image:
c.f. #338
Please do comment