-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manylinux2010-i686 docker image #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veblush, can you update the .travis.yml
for the image to be built please ?
@mayeut, I added i686 test to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Waiting for auditwheel release
Thank you for the review! And then how can we initiate the auditwheel release process? Once it's released with the next version (let's say 2.2) and next action item would be to update |
Well yes but not in your PR directly, once auditwheel gets released, a PR will be automatically created for the master branch. Once this PR is merged, you'll need to rebase your branch on master (& if possible squash the commits in one) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veblush, can you rebase & squash your changes please ?
Done. I appreciate your help on this! 😄 |
Grad to see this merged. Is there something to do in order to have |
Should be a matter of time, you can follow the progress here |
argh, build failed because the repo does not exist on @njsmith, @rmcgibbo, @takluyver, can you create the repo |
done. i think |
Thanks @rmcgibbo, I restarted the build, we'll see if it gets deployed this time. |
I've had a go at making the permissions for that repo match the other manylinux2010 one - try now. |
Or I guess I can press restart as well as anyone else. 😛 I'm going to bed now, so hopefully it will work this time. |
Thanks @takluyver, image is now deployed. |
Thanks everyone who figured out how to make the i686 image. :-) |
Thank you for uploading! |
I roughly manage to create a manylinux2010-i686 docker image based on CentOS 6. CentOS 6 is pretty old and i686 doesn't get enough attention so there are a couple of issues to be resolved unlike x86_64.
CentOS 6 has a problem on curl with installed certificates so I have to add "-k" option to curl as a workaround. (I tried to update the existing system certificate but it didn't work)Any suggestion to enhance this is welcome!