Add s390x support #392
Merged
Add s390x support #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mattip
reviewed
Nov 14, 2019
| @@ -0,0 +1,19 @@ | |||
| FROM s390x/clefos:7 | |||
There was a problem hiding this comment.
This is what was missing to get gh-391 going. For future reference, how did you know what to specify here?
There was a problem hiding this comment.
For future reference, how did you know what to specify here?
Well, I didn't know. I googled around, found this: http://containerz.blogspot.com/2017/07/an-overview-on-s390x-base-images.html which lead me there https://hub.docker.com/_/clefos to gather the fact that the image was part of docker official images (i.e. good enough to use as a base image without too much further research) and https://www.sinenomine.net/products/linux/clefos (official page, mostly to gather if devtoolset-8 was part of the package list or not).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis-ci now provides s390x support, let's propose a s390x image.