Image versioning: Tag each docker build with a unique id, and push that to quay.io #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at cibuildwheel we've been talking about how we might get some determinism in the build process (pypa/cibuildwheel#239), and the manylinux image is one of those things we'd like to lock down.
This PR introduces a docker tag, alongside
latest
, of the formatYYYY-MM-dd-gitsha
, for example2020-01-18-dea2616
. Each build is tagged, and the tag is pushed to quay.io.I have tested this on my fork, with Travis building and uploading - see https://quay.io/repository/joerick/manylinux2010_x86_64?tab=tags for how these end up in quay.io.
Thanks!
Fixes #111