Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image versioning: Tag each docker build with a unique id, and push that to quay.io #440

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

joerick
Copy link
Contributor

@joerick joerick commented Jan 18, 2020

Over at cibuildwheel we've been talking about how we might get some determinism in the build process (pypa/cibuildwheel#239), and the manylinux image is one of those things we'd like to lock down.

This PR introduces a docker tag, alongside latest, of the format YYYY-MM-dd-gitsha, for example 2020-01-18-dea2616. Each build is tagged, and the tag is pushed to quay.io.

I have tested this on my fork, with Travis building and uploading - see https://quay.io/repository/joerick/manylinux2010_x86_64?tab=tags for how these end up in quay.io.

Thanks!

Fixes #111

@auvipy auvipy requested a review from mayeut January 18, 2020 14:43
@joerick
Copy link
Contributor Author

joerick commented Jan 28, 2020

Any thoughts, @mayeut ?

@mayeut
Copy link
Member

mayeut commented Jan 29, 2020

@joerick,
I'm going to merge this but there might be a need to define a retention strategy in order not to store too much over the years.
Given it's been less than 100GB/year and that quay.io states an unlimited storage in its FAQ, that seems ok for now but nevertheless, we should think about that.

Can you create similar PRs for manylinux1 & manylinux2014 branches ?
Thanks

@mayeut mayeut merged commit 63f5543 into pypa:master Jan 29, 2020
joerick added a commit to joerick/manylinux that referenced this pull request Jan 31, 2020
@joerick joerick mentioned this pull request Jan 31, 2020
joerick added a commit to joerick/manylinux that referenced this pull request Jan 31, 2020
@joerick
Copy link
Contributor Author

joerick commented Jan 31, 2020

Can you create similar PRs for manylinux1 & manylinux2014 branches ?

Done, see #470 and #471.

there might be a need to define a retention strategy in order not to store too much over the years.

Hm, yes. If quay.io could provide download stats, they could be used to delete images that weren't being used any more. I can't see that anywhere currently...

@joerick
Copy link
Contributor Author

joerick commented Jan 31, 2020

Thank you @mayeut !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce image versioning
3 participants