Dependency specifiers grammar fixes #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise would `numpy @ https://example.org/numpy` is not a valid specifier (missing whitespace after the URL). This already what pip and packaging do and also what the parsley grammar says
Otherwise `numpy; os_namein 'posix'` would be a valid specifier which it isn't
Otherwise `numpy; os_name in'posix'` and `numpy; os_name inos_name` would be valid. pypa/packaging 22.0 actually allows currently `numpy; os_name in'posix'`
chrysle
approved these changes
Jun 3, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three changes:
Dependency Specifiers: Don't require whitespace after URL
otherwise
numpy @ https://example.org/numpyis not a valid specifier (missing whitespace after the URL). This already what pip and packaging do and also what the parsley grammar saysDependency Specifiers: Require whitespace before in and not in
Otherwise
numpy; os_namein 'posix'would be a valid specifier which it isn'tDependency Specifiers: Require whitespace after in and not in
Otherwise
numpy; os_name in'posix'andnumpy; os_name inos_namewould be valid. pypa/packaging 22.0 actually allows currentlynumpy; os_name in'posix', but i argue there should be a whitespace afterinandnot injust like in python itself