Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discussion "Distribution package vs. import package" #1426

Merged
merged 14 commits into from
Dec 17, 2023
Merged

Add discussion "Distribution package vs. import package" #1426

merged 14 commits into from
Dec 17, 2023

Conversation

jeanas
Copy link
Contributor

@jeanas jeanas commented Dec 1, 2023 •
edited by webknjaz
Loading

@jeanas @sinoroc
Update source/discussions/distribution-package-vs-import-package.rst
176f956 
Co-authored-by: sinoroc <5529267+sinoroc@users.noreply.github.com>
@LLyaudet LLyaudet mentioned this pull request Dec 1, 2023
Open
@willingc willingc added the diataxis: explanation Understanding oriented discussion (https://diataxis.fr/explanation/) label Dec 1, 2023
@webknjaz webknjaz mentioned this pull request Dec 3, 2023
Merged
@jeanas jeanas mentioned this pull request Dec 13, 2023
Merged
@jeanas
Copy link
Contributor Author

jeanas commented Dec 14, 2023

I've tried to address all comments. @webknjaz Could you take another look when you have a chance?

jeanas and others added 2 commits December 16, 2023 08:26
@jeanas @webknjaz
The PyPI
d4164d2 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@jeanas
Python software -> Python libraries and tools
62273fe
webknjaz
webknjaz approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Thank you for seeing this through!

@webknjaz webknjaz added this pull request to the merge queue Dec 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2023
@webknjaz webknjaz added this pull request to the merge queue Dec 17, 2023
Merged via the queue into pypa:main with commit 84b5491 Dec 17, 2023
5 checks passed
@jeanas jeanas deleted the distribution-vs-import-package branch December 17, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson left review comments

@woodruffw woodruffw woodruffw left review comments

@willingc willingc willingc left review comments

@sinoroc sinoroc sinoroc approved these changes

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
diataxis: explanation Understanding oriented discussion (https://diataxis.fr/explanation/)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a discussion on distribution packages vs. import packages
6 participants
@jeanas @webknjaz @willingc @woodruffw @sinoroc @sethmlarson