fix: Remove '<4' from python_requires in packaging guide #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in https://discuss.python.org/t/use-of-less-than-next-major-version-e-g-4-in-python-requires-setup-py/1066 and other places there can be some side effects of adding `<4` to a library's python_requires. This PR removes it, as requested in the discuss.python question. The section above the lines discussed in the topic that uses compatible release syntax is also removed given that `~=3.3` also enforces `<4`. Additional references of problems known to Matthew for posterity: * Twitter threads: - https://twitter.com/HEPfeickert/status/1362170933658738701 - https://twitter.com/nicholdav/status/1366978826790666240 * GitHub Issues: - python-poetry/poetry#3747
henryiii
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Keep in mind, unlike for libraries (where honestly this is still a poor idea for a general library pin), using Requires-Python causes pip to scroll back through history to find the first matching version that does not have a Requires-Python slot that does not include the current Python. This is never correct for a "future" version, but can only be used for the use case it was designed for - dropping a version that you used to support.
pfmoore
approved these changes
Mar 3, 2021
webknjaz
approved these changes
Mar 3, 2021
|
For posterity, related to: nedbat/coveragepy#1021 |
This was referenced Aug 26, 2022
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the discuss.python topic "Use of “less-than next-major-version” (e.g.,
<4) inpython_requires(setup.py)" and other places there can be some side effects of adding<4to a library'spython_requires. This PR removes it, as requested by @njsmith in the discuss.python topic.The section above the lines discussed in the topic that uses compatible release syntax is also removed given that
~=3.3also enforces<4.My apologies in advance if this was already discussed in an Issue and decided against (I didn't see any when I scrolled through) or in a previously closed PR. Please let me know if you'd like me to open an Issue to discuss this PR topic instead.
Tagging @pfmoore and @njsmith as they were the devs in the discuss.python topic and @NickleDave and @henryiii as they might be interested in this as well.