-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PEP 685 #526
Comments
I think if we update: packaging/packaging/markers.py Lines 141 to 145 in ba12432
... to coerce packaging/packaging/markers.py Lines 189 to 201 in ba12432
... or: packaging/packaging/markers.py Lines 230 to 240 in ba12432
There's also separate work for requirements for the packaging/packaging/requirements.py Line 121 in ba12432
|
Thanks to @hroncok we have a PR to normalize the comparison. I have an in-progress PR on my local machine which normalizes for the string representation of markers. |
BTW I am sorry for not searching for this issue first. I should have and I have no idea why I haven't :( |
No worries! My in-progress PR isn't wasted regardless since the hardest part in it is normalizing at parse time for |
This guarantees that getting the string representation of a marker is always normalized for extras. Part of pypa#526
This guarantees that getting the string representation of a marker is always normalized for extras. Part of #526
Now that |
Any update on this? |
I think we can declare this as done as it's going to be for now. 😁 I just pushed the docs for |
Nice! Any ETA for pip to upgrade its bundled copy of this? |
That's a @pradyunsg question. |
If we cut a packaging release early in this month (say, next week or so) then it'd be in pip 22.2 (due by end of month). |
22.2 was released |
@ofek not sure if that comment was meant to point this out too but this didn't make it into |
Ah, sorry to double post, but I see #569 is the ticket asking for a release, so this is still "blocked" on that on the pip side if I understand correctly. |
https://peps.python.org/pep-0685/
extra
comparisonsUpdaterequirements.Requirement.extras
to raise a warning when names clashpackaging.utils.canonical_name()
utils.NormalizedName
#495The text was updated successfully, but these errors were encountered: