-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Present a clearer error message when the user misses a space before ;
in marker
#529
Comments
I think this was supposed to refer to
is not a valid marker string. |
In #624, these cases get an error like:
|
Could the arrow's position be adjusted so that it points at the semicolon's position (since that's where the space is missing)? I think that it pointing at the first letter of the marker is confusing. // #592 also hints directly that it might be the space between URL and semicolon that's missing while in your error it IMO seems a bit less clear. But I guess users will probably be able to figure it out just fine anyway so I wouldn't say it's a big deal. |
Yea, I flip-flopped on those aspects (I think that might actually be visible in the force-push history), and ended up on this style since it was consistent with how "bad" versions specifiers ended up being handled:
|
Granted all of the options we have at hand are improvements over the current variant. :)
|
Currently, if you try to use:
The error you get is:
It would be good if it presented an error that suggested adding a
(space) before the semicolon.
The text was updated successfully, but these errors were encountered: