-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaces in platform names are problematic #652
Comments
Can you point where in the And the "fun" part of this is https://peps.python.org/pep-0425/#platform-tag doesn't specify what to do with spaces (and actually, "space" is not mentioned once in the PEP). |
If we use
AFAICT, the only alternative would be to have Footnotes
|
OK, that makes sense. In #620 (comment) , @tucked noticed we now have a test that's explicitly checking an example with spaces, but I think that's just for parsing purposes and not normalization. But to double-check, @mattip , do you see any reason not to do this since I think you may have written the test in question? @pradyunsg you okay with this change? |
Yup! Do we want to update the spec language to cover spaces -> underscore? |
The test was only meant to check round-trip behavior. It should not use spaces. |
I think so, but I think it's going to require bringing PEP 425 over to packaging.python.org first. |
Is this not covered in PEP 427:
|
Technically it doesn't matter because that's not the spec anymore (as the top of the PEP says). The spec is now https://packaging.python.org/en/latest/specifications/binary-distribution-format/#escaping-and-unicode and it actually doesn't mention anything about spaces, just that the wheel tags need to be valid. And the wheel tag spec at https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/ redirects to PEP 425 which also lacks an opinion. |
Also update to say spaces are not allowed in wheel tags (see pypa/packaging#652 ).
I opened pypa/packaging.python.org#1206 to move PEP 425 over to packaging.python.org. |
Also update to say spaces are not allowed in wheel tags (see pypa/packaging#652 )
On some platforms,
sysconfig.get_platform()
returns a value with a space in it (e.g.isilon onefs
).This causes problems for wheel building/handling.
First, there is an issue trying to build a platform-specific wheel:
I created pypa/wheel#491 to address this.
Even with that patch in place, though,
pip
is unable to install the built wheel becausepackaging
does not recognize that the platform name has had its spaces replaced with underscores:The text was updated successfully, but these errors were encountered: