-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra environment marker should evaluate correctly. #116
Conversation
Well, safe extras/names cause tests to fail. So there’s that. |
129f5cd
to
d2ed39a
Compare
Last merge breaks tons of stuff, but is a rough idea of what should be done. |
What does the error generated in the last test mean?
This branch is working perfectly on my local box. Is this a problem with Travis? Or repo settings? Or there something wrong with my code . . . |
@GabrielC101 |
Thanks! @xavfernandez |
This PR will create a special rule for Markers that consist of It seems name normalization isn't implemented in packaging. The canonicalize_name function was introduced for PEP 503 compliance. But it's never been implemented. It's only called by testing files. Does anyone object to this approach? Will implementing name normalization open up a can of worms? Does anyone want to share some constructive criticism? I'm worried my approach is too ad-hoc, and parsing/normalization should be more systematic. Any help/thoughts is appreciated. |
2faebb1
to
335e240
Compare
335e240
to
fc7d3db
Compare
99fb2e4
to
9f233a8
Compare
Closing since #545 solved the problem that this PR was intended to solve! Thanks for filing this PR @GabrielC101! ^>^ |
Requirement class should convert names to "safe"/"canonicalized" names. I've used some functions from setuptools to accomplish this (copied and pasted them). The canonicalized method did something slightly different.
I believe this issue has manifested itself in pypa/pip#4617
I've been researching this in pypa/pip#4901
Is the safe/canonicalize discrepancy an issue?