Fix workflows #227
Merged
Fix workflows #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And of course, the checks aren't going to run here since no docs or @brettcannon What's the rationale for restricting the workflow runs like this? Any reason not to just make them run with every PR/push like Travis is currently configured? |
|
@di "What's the rationale for restricting the workflow runs like this?" If you're asking why "push" over "PR" it was to wait until they were stable enough to warrant relying on them. If you're asking why not run all steps for all PRs no matter what, I was just trying to not burn some coal somewhere for no good reason. |
brettcannon
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to get a "Run failed" notification after merging #226.
This PR fixes a broken workflow, and also runs the workflows on every PR so we can see if they're broken before merging.