-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a pp3-none-any
tag
#466
Conversation
Rebased to pull in #467 |
Won't this affect PyPy 2's tags since it's hard-coded to |
I think the trove classifier specifies "Programming Language :: Python :: 3 :: Only" so python2 is not relevant, correct? |
Co-authored-by: Brett Cannon <brett@python.org>
I'm thinking from a tag perspective. If I'm reading the code right, the logic right now only checks if the interpreter type is |
The code cannot be called by pypy2, it errors out on the typing sytax Line 30 in 42e1396
|
Co-authored-by: Brett Cannon <brett@python.org>
LGTM; just waiting on CI after fast-forwarding to the latest on |
Closes #311. Now that this project is used by pip and wheel, the discussion there about where to make the change is less relevant, I hope that reading the description below convinces the maintainers that the change is justified.
This inserts a pp3-none-any tag as the first any-platform tag.
This subject came up again for the vmprof project, which is a statistical profiler for cpython/pypy. The project has two parts: a pure-python front end, and a backend. On CPython, the backend is a c-extension module. On PyPy, the backend is built into the interpreter and understands the JIT. So when making wheels for the project, we want c-extension binary wheels for CPython and a pure-python wheel for PyPy.
Here is a snippet of the output of
tags.sys_tags()
using PyPy 3.7 on ubuntu 20.04/x86_64.