Fix failing parse action #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pyparsing 3.0.5 renamed the two private attributes that are used here. This exact same transformation is performed by `originalTextFor`'s default action, and assuming the intention was simply to construct a `Marker` from the matched string, I've restored the default action and added a secondary action for constructing the `Marker` object.
The tests would run with pyparsing 2 because packaging is a dependency of pytest and the latest published version requires `pyparsing >=2, <3`.
To see what gets installed.
|
#487 is now a competing PR to fix the same issue. |
|
Neither PR has gained any traction and the author of pyparsing has graciously restored these private attributes in v3.0.6, so I'll go ahead and close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #486
pyparsing 3.0.5 renamed the two private attributes that are used
here. This exact same transformation is performed by
originalTextFor's default action, and assuming the intentionwas simply to construct a
Markerfrom the matched string, I'verestored the default action and added a secondary action for
constructing the
Markerobject.