-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tags: accept mac tags without minor versions #579
base: main
Are you sure you want to change the base?
Conversation
This is just an initial proposal for the fix. @lawrence-danna-apple can you clarify on the Apple policy? Is the version only omitted starting from 12 and onwards? Is it always omitted, or should we keep the |
d125185
to
0a9ef80
Compare
e1ee4b8
to
0d4dcaf
Compare
Signed-off-by: Filipe Laíns <lains@riseup.net>
0d4dcaf
to
8405a84
Compare
) | ||
# Mac OS 11 and 12 seem to omit the minor version, we will keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is going to be confusing, see #578 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor-free tags should come after all minor-including tags, not replace them.
Fixes #578