Implement name normalization from PEP 503 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstufft
force-pushed
the
normalize-func
branch
2 times, most recently
from
1140d8d to
ac90a0f
Compare
| ("foo.bar", "foo-bar"), | ||
| ("Foo.Bar", "foo-bar"), | ||
| ("foo_bar", "foo-bar"), | ||
| ("foo-bar", "foo-bar"), |
There was a problem hiding this comment.
maybe ("foo___bar", "foo-bar") also ?
dstufft
force-pushed
the
normalize-func
branch
from
ac90a0f to
61ac163
Compare
dstufft
force-pushed
the
normalize-func
branch
from
61ac163 to
deb5846
Compare
dstufft
added a commit
that referenced
this pull request
Feb 9, 2016
Implement name normalization from PEP 503
|
What about illegal names? e.g. ^foo |
|
We just pass them through. This function doesn't attempt to limit what names are acceptable, it just implements the canonicalization rules, which are:
Anything else is just passed through unmodified (in PyPI's case, we have something else ensuring the names are valid, in packaging we have that rule encoded into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.