Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor nox requirements to use requirements files (#601) #609

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Refactor nox requirements to use requirements files (#601) #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def tests(session):
def coverage(*args):
session.run("python", "-m", "coverage", *args)

session.install("coverage[toml]>=5.0.0", "pretend", "pytest>=6.2.0", "pip>=9.0.2")
session.install("-r", "tests/requirements.txt")
session.install(".")

if "pypy" not in session.python:
Expand Down Expand Up @@ -69,7 +69,7 @@ def lint(session):
@nox.session(python="3.9")
def docs(session):
shutil.rmtree("docs/_build", ignore_errors=True)
session.install("furo")
session.install("-r", "docs/requirements.txt")
session.install("-e", ".")

variants = [
Expand Down
4 changes: 4 additions & 0 deletions tests/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
coverage[toml]>=5.0.0
pip>=9.0.2
Copy link
Member

@uranusjr uranusjr Nov 7, 2022 •
edited by brettcannon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really related to this PR, but is this line still relevant now that we require Python 3.7+?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, but technically you don't have to have pip installed in an environment either, so I don't think it's hurting anything by being explicit.

pretend
pytest>=6.2.0