Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle non-normalised specifiers in requirements #634

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Correctly handle non-normalised specifiers in requirements #634

merged 3 commits into from
Dec 8, 2022
+12 −16

Commits on Dec 8, 2022

  1. Use regular expression from specifiers as-is for requirement parsing 

    Using the exact same patterns as `Specifier` helps ensure that the
same parsing behaviour is seen for specifiers on their own as well as
specifiers within requirements.
    @pradyunsg
    pradyunsg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d4b6377 View commit details
    Browse the repository at this point in the history

  2. Reorder specifier matching to try longer names first 

    This ensures that a non-greedy match still preferentially matches the
longer format.
    @pradyunsg
    pradyunsg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    bee120f View commit details
    Browse the repository at this point in the history

  3. Add a test case for non-normalised specifiers 

    This validates that the specifier is parsed correctly.
    @pradyunsg
    pradyunsg committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    946989c View commit details
    Browse the repository at this point in the history