Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable Python 3.11 in tests #641

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Use stable Python 3.11 in tests #641

merged 1 commit into from
Dec 13, 2022

Conversation

153957
Copy link
Contributor

@153957 153957 commented Dec 12, 2022

Since 3.11 has been out for a while now, the tests should probably use the latest stable instead of dev version.

Should the changes to remove the -dev suffix for nox also be removed?
Or keep that, but also add Python 3.12-dev to the tests? Configured in such a way that those tests are allowed to fail.

@henryiii
Copy link
Contributor

There is a 3.12 dev release, maybe worth trying? Might be unstable, but would be good to start testing a version without distutils sooner rather than later? :)

@153957
Copy link
Contributor Author

153957 commented Dec 13, 2022

Here is a guide on how to set this up, including allowing the 3.12 to fail and still call the tests a success; https://pythontest.com/testing-with-python-3-12/#what-if-312-fails-but-i-dont-want-my-pipeline-to-stop

@henryiii
Copy link
Contributor

@brettcannon brettcannon self-assigned this Dec 13, 2022
@brettcannon brettcannon reopened this Dec 13, 2022
@brettcannon brettcannon merged commit 5e446f7 into pypa:main Dec 13, 2022
@153957 153957 deleted the patch-1 branch December 14, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants