Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parser error messaging around mistakes in/around version specifiers #662

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Improve parser error messaging around mistakes in/around version specifiers #662

merged 3 commits into from
Jan 16, 2023

Commits on Jan 14, 2023

  1. Stop yielding a value that isn't used

    @pradyunsg
    pradyunsg committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    e28e4ff View commit details
    Browse the repository at this point in the history

  2. Indicate expected content between mismatched tokens in parse errors 

    This provides more context to users about what the parser would've been
expecting. This can make it easier to understand what the underlying
issue might be.
    @pradyunsg
    pradyunsg committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    d8dfc67 View commit details
    Browse the repository at this point in the history

  3. Add dedicated error for specifiers with incorrect .* suffix 

    This should make it clearer how and why this is not valid, thus
providing relevant context to readers.
    @pradyunsg
    pradyunsg committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    e58d4f6 View commit details
    Browse the repository at this point in the history