Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_dependency_source/pip: Log a warning and skip auditing for packages with invalid versions #139

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

tetsuo-cpp
Copy link
Contributor

Closes #138

@tetsuo-cpp tetsuo-cpp requested a review from woodruffw November 28, 2021 12:35
@di
Copy link
Member

di commented Nov 28, 2021

Would it make sense to list dependencies that can't be audited in the summary / JSON output as well?

I also think this would be something users might want to influence whether the audit passes or fails. Perhaps we want a --strict mode that makes the presence of an unauditable dependency a failure?

@di
Copy link
Member

di commented Nov 28, 2021

(Doesn't have to happen in this PR, just thinking about what we should do with unauditable dependencies long-term)

@tetsuo-cpp
Copy link
Contributor Author

@di
I like these ideas. I've created #141 and #142 to track them.

@woodruffw
Copy link
Member

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version strings that don't conform to PEP 440 cause a failed audit
3 participants