requirement: handle VCS URLs correctly in pinned mode #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodruffw
added
component:cli
|
cc @Zac-HD for visibility -- this unfortunately won't address your use case, but it'll at least check the error correctly and clarify that |
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
|
@Zac-HD I believe this now will address your use case! Thanks for bearing with me 🙂 |
di
approved these changes
Oct 31, 2022
|
🙏 Thank you for your careful thought about how to handle this correctly, and for all the work you (and @di) do to maintain such useful tooling for the whole ecosystem 🥰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "fixes" #382 by:
1. Turning the unchecked exception into a controlled error2. Fixing the error message (clarifying thatpipdoesn't support version pinning on URLs (VCS or otherwise), meaning that URL requirements cannot be used with--no-depsor `--require-hashes)--no-depsmode, which is compatible with howpip --no-depsbehavesCloses #382.