Skip to content

Commit

Permalink
Return early for clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
pradyunsg committed Jul 16, 2020
1 parent eafbec5 commit 7ddbcc2
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/pip/_internal/commands/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -507,15 +507,14 @@ def _handle_target_dir(self, target_dir, target_temp_dir, upgrade):
def _determine_conflicts(self, to_install):
# type: (List[InstallRequirement]) -> Optional[ConflictDetails]
try:
conflict_details = check_install_conflicts(to_install)
return check_install_conflicts(to_install)
except Exception:
logger.error(
"Error while checking for conflicts. Please file an issue on "
"pip's issue tracker: https://github.com/pypa/pip/issues/new",
exc_info=True
)
return None
return conflict_details

def _warn_about_conflicts(self, conflict_details):
# type: (ConflictDetails) -> None
Expand Down

0 comments on commit 7ddbcc2

Please sign in to comment.