freeze: deprecate option --find-links

pypa · Oct 30, 2020 · c33cf49 · c33cf49
1 parent 8ae1bd6
commit c33cf49
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/news/9069.removal.rst b/news/9069.removal.rst
@@ -0,0 +1 @@
+Deprecate ``--find-links`` option in ``pip freeze``
diff --git a/src/pip/_internal/commands/freeze.py b/src/pip/_internal/commands/freeze.py
@@ -9,6 +9,7 @@
 from pip._internal.models.format_control import FormatControl
 from pip._internal.operations.freeze import freeze
 from pip._internal.utils.compat import stdlib_pkgs
+from pip._internal.utils.deprecation import deprecated
 from pip._internal.utils.typing import MYPY_CHECK_RUNNING
 
 DEV_PKGS = {'pip', 'setuptools', 'distribute', 'wheel'}
@@ -86,6 +87,14 @@ def run(self, options, args):
 
         cmdoptions.check_list_path_option(options)
 
+        if options.find_links:
+            deprecated(
+                "--find-links option in pip freeze is deprecated.",
+                replacement=None,
+                gone_in="21.2",
+                issue=9069,
+            )
+
         freeze_kwargs = dict(
             requirement=options.requirements,
             find_links=options.find_links,

diff --git a/tests/functional/test_freeze.py b/tests/functional/test_freeze.py
@@ -358,7 +358,8 @@ def test_freeze_mercurial_clone_srcdir(script, tmpdir):
     _check_output(result.stdout, expected)
 
     result = script.pip(
-        'freeze', '-f', '{repo_dir}#egg=pip_test_package'.format(**locals())
+        'freeze', '-f', '{repo_dir}#egg=pip_test_package'.format(**locals()),
+        expect_stderr=True,
     )
     expected = textwrap.dedent(
         """
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Deprecate ``--find-links`` option in ``pip freeze``