PR feedback

pypa · Apr 19, 2019 · c6036b7 · c6036b7
1 parent 3a40284
commit c6036b7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/news/6419.bugfix b/news/6419.bugfix
@@ -1 +1 @@
-Fix NameError when handling InvalidRequirement in install_req_from_req_string.
+Fix ``NameError`` when handling an invalid requirement.
diff --git a/tests/unit/test_req_install.py b/tests/unit/test_req_install.py
@@ -55,9 +55,13 @@ def test_install_req_from_string_invalid_requirement(self):
         Requirement strings that cannot be parsed by
         packaging.requirements.Requirement raise an InstallationError.
         """
-        with pytest.raises(InstallationError):
+        with pytest.raises(InstallationError) as excinfo:
             install_req_from_req_string("http:/this/is/invalid")
 
+        assert str(excinfo.value) == (
+            "Invalid requirement: 'http:/this/is/invalid'"
+        )
+
     def test_install_req_from_string_without_comes_from(self):
         """
         Test to make sure that install_req_from_string succeeds
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		Fix NameError when handling InvalidRequirement in install_req_from_req_string.
		Fix ``NameError`` when handling an invalid requirement.