Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch vendored packaging library to support --disable-gil (PEP 703) builds #12634

Closed
1 task done
colesbury opened this issue Apr 17, 2024 · 1 comment
Closed
1 task done
Labels
type: feature request Request for a new feature
Milestone

Comments

@colesbury
Copy link

What's the problem this feature will solve?

The current version of pip does not support the free-threaded builds of CPython 3.13 due to using an older version of the packaging library. Currently, pip 24.0 will install incompatible stable ABI wheels and also refuse to install compatible wheels in the free-threaded build.

#12300 upgrades the vendored packaging library, but the PR still has unresolved issues that are unrelated to support for the free-threaded CPython build.

Describe the solution you'd like

As a stopgap measure, let's patch the vendored packaging library with the changes from pypa/packaging#728 in order to support the free-threaded build.

This decouples support for free-threaded CPython and removal of legacy version specifiers. Supporting free-threaded CPython is fairly straightforward, while the removal of legacy versions and version specifiers is complex.

Alternative Solutions

Alternatively, we can wait for the remaining issues in #12300 to be addressed.

Additional context

The May 7 beta release of Python 3.13 is coming up soon. If possible, I'd really like to have a version of pip that works with the free-threaded build before then.

Code of Conduct

@colesbury colesbury added S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Apr 17, 2024
colesbury added a commit to colesbury/pip that referenced this issue Apr 17, 2024
This applies pypa/packaging#728 as a stopgap
measure to support the free-threaded builds of CPython. That PR is
already merged upstream, but a full upgrade of the packaging library is
more complicated due to removal of legacy versions and version
specifiers.

Closes pypa#12634
@pradyunsg pradyunsg removed the S: needs triage Issues/PRs that need to be triaged label Apr 19, 2024
@pradyunsg pradyunsg added this to the 24.1 milestone Apr 19, 2024
@pradyunsg
Copy link
Member

Closing this out since #12300 has merged.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants