Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopting black (and linter updates!) #8543

Closed
pradyunsg opened this issue Jul 5, 2020 · 2 comments · Fixed by #10360
Closed

Adopting black (and linter updates!) #8543

pradyunsg opened this issue Jul 5, 2020 · 2 comments · Fixed by #10360
Assignees
Labels
type: maintenance Related to Development and Maintenance Processes

Comments

@pradyunsg
Copy link
Member

Follow up to #7084

There's basically 2 broad tasks here:

  • Upgrade all of our linting tools to the latest versions (especially isort).
  • Adopt black for formatting code, enforcing a consistent code style.

This should be done after the pip 20.2 release has been made, to minimise any potential disruption to the release planning/process.

@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label Jul 5, 2020
@pradyunsg pradyunsg self-assigned this Jul 5, 2020
@pradyunsg
Copy link
Member Author

Self-assigned because I'd like to do this myself.

This was referenced Sep 23, 2020
@pradyunsg pradyunsg changed the title Linting improvements (Aug 2020) Linter updates and adopting black Sep 23, 2020
@pradyunsg
Copy link
Member Author

pradyunsg commented Sep 23, 2020

#8902 updated the linters, so this is now the tracking issue for adopting black in pip's codebase.

#8903 is the "big fat PR" and @uranusjr + @pfmoore + @webknjaz rightfully pointed out that it's too big and we should break it up. #8906 is the first step in that direction.

@pradyunsg pradyunsg changed the title Linter updates and adopting black Adopting black (and linter updates!) Sep 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance Related to Development and Maintenance Processes
Projects
None yet
1 participant