Blacken the rest of the codebase, in one go #10360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
changed the title
pradyunsg
force-pushed
the
blacken-everything
branch
3 times, most recently
from
c9ca912
to
9523580
Compare
sbidoul
added
the
skip news
sbidoul
approved these changes
Aug 15, 2021
DiddiLeija
approved these changes
Aug 15, 2021
github-actions
bot
added
the
needs rebase or merge
jdufresne
approved these changes
Aug 19, 2021
.pre-commit-config.yaml
Outdated
| ^tests/functional/test_install| | ||
| # A blank ignore, to avoid merge conflicts later. | ||
| ^$ | ||
| exclude: src/pip/_vendor/ |
There was a problem hiding this comment.
Suggested change
| exclude: src/pip/_vendor/ |
I believe this line can be dropped as _vendor is already excluded globally on line 1.
pradyunsg
force-pushed
the
blacken-everything
branch
from
9523580
to
585037a
Compare
|
I'm gonna go ahead and merge this now; since no one has said "Don't do this!?!" in #10299. I'll also enable the news check, since a whole bunch of PRs are gonna be updated for the conflicts this causes; so they'd also end up getting the newer news checking workflow as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8543
Closes #10299
Closes #10359
Closes #10285
In case we decide to do this in #10299.