-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform merge-conflict label checks, via GitHub Actions #10363
Conversation
I didn’t read the implementation; does this add a “heyyou have conflicts” comment on the PR? Because that previous behaviour was a bit annoying at times when a PR went through multiple conflicts; if the bot had to comment, it should also delete it after the conflict was resolved. |
Nope.
I didn't quite like that behaviour either TBH. While I get the "trigger a notification to inform the author", it was usually not super useful. I think what we'd want is the behaviour described in eps1lon/actions-label-merge-conflict#40 (different action with more capabilities). I'm subscribed there so if there's movement (or if I actually end up implementing that), then we can switch to that action and bring back the commenting behavior. Until then, I'd prefer to stick to the simpler implementation that doesn't write any comments. |
Do you want to add a name to the workflow? Or is If we are including a name: Merge-conflict check # or name you like the GitHub interface might look better, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this out.
Had the editor open, so I've done that. |
b14f217
to
eb700d7
Compare
AHAHAA. I forgot I had enabled this restriction. We'll know on the next commit to For fellow maintainers wondering, https://github.com/pypa/pip/settings/actions is where the list is. |
Merged #10292, which has triggered https://github.com/pypa/pip/runs/3333336093?check_suite_focus=true. |
What can we do now to solve this problem? |
@DiddiLeija Thanks for taking a look. I got distracted by Mini Motorways. :) |
Let's try it, and see how it works?