Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when egg-link does not match installed location #10594

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Improve error message when egg-link does not match installed location #10594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebee1ce
Improve error message when egg-link does not match installed location
matpdegroote2 Oct 17, 2021
ae9c0fd
Add news entry for improved error message
matpdegroote2 Oct 20, 2021
01b1388
Merge branch 'main' into main
pradyunsg Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/10476.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Specify egg-link location in assertion message when it does not match installed location to provide better error message for debugging.
4 changes: 2 additions & 2 deletions src/pip/_internal/req/req_uninstall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,8 +535,8 @@ def from_dist(cls, dist: BaseDistribution) -> "UninstallPathSet":
assert os.path.samefile(
normalized_link_pointer, normalized_dist_location
), (
f"Egg-link {link_pointer} does not match installed location of "
f"{dist.raw_name} (at {dist_location})"
f"Egg-link {develop_egg_link} (to {link_pointer}) does not match "
f"installed location of {dist.raw_name} (at {dist_location})"
)
paths_to_remove.add(develop_egg_link)
easy_install_pth = os.path.join(
Expand Down