Fix our documentation build and changelog rendering #10607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow newer versions of Sphinx, which contain bugfixes for Python 3.10 support.
pradyunsg
force-pushed
the
fix-docs-builds
branch
from
05d0663
to
4144d6a
Compare
|
Oh no race condition |
pradyunsg
added
the
skip news
|
Relevant here: sphinx-doc/sphinx#9646 |
|
Hmm, towncrier rendering seems broken |
towncrier renders with `trim_blocks=True` which trims the newline at the start of the for loop's body. This adds an additional newline which is not trimmed, which ensures that the code blocks don't blend into each other.
Indeed! Nice catch! ^>^ Fixed! I never tested with multiple bullets in the same section. I guess, good thing we have had so many PRs. XD |
uranusjr
approved these changes
Oct 22, 2021
pradyunsg
changed the title
uranusjr
reviewed
Oct 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow newer versions of Sphinx, which contain bugfixes for
Python 3.10 support.
Also fixes towncrier template for multiple bullets.