Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional truststore support #11082

Merged
merged 2 commits into from
May 30, 2022
Merged

Optional truststore support #11082

merged 2 commits into from
May 30, 2022

Commits on May 3, 2022

  1. Optional truststore support 

    This adds a --use-feature=truststore flag that, when specified on Python
3.10+ with truststore installed, switches pip to use truststore to
provide HTTPS certificate validation, instead of certifi. This allows
pip to verify certificates against custom certificates in the system
store.

truststore is deliberately NOT vendored because it is expected the
library to be under active development in the short term, and this
prevents users having to wait for a pip release to get potentially vital
bug fixes needed to be made in truststore.

Supplying the use-feature flag without installing truststore beforehand,
or on Python versions prior to 3.10, results in a command error.
    @uranusjr
    uranusjr committed May 3, 2022
    Configuration menu
    Copy the full SHA
    f4962cc View commit details
    Browse the repository at this point in the history

  2. Add very simple tests to ensure feature is enabled

    @uranusjr
    uranusjr committed May 3, 2022
    Configuration menu
    Copy the full SHA
    a020e8c View commit details
    Browse the repository at this point in the history