Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check for wheel when only build-system.requires is present #11674

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Don't check for wheel when only build-system.requires is present #11674

merged 2 commits into from
Dec 27, 2022

Conversation

Jackenmen
Copy link
Contributor

Fixes #11673

@Jackenmen Jackenmen marked this pull request as ready for review December 26, 2022 17:28
uranusjr
uranusjr approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to my reserch wheel has always been included since the backend’s inception, so this should be good.

@pradyunsg pradyunsg merged commit 8dbb8b9 into pypa:main Dec 27, 2022
@pradyunsg
Copy link
Member

Thanks @Jackenmen!

@Jackenmen Jackenmen deleted the patch-1 branch December 27, 2022 09:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing warning about missing 'wheel' when building a project that only has build-system.requires
3 participants
@Jackenmen @pradyunsg @uranusjr