Use -r=... instead of -r ... for VCS CLI

[pradyunsg]

This ensures that the resulting revision can not be misinterpreted as an option.

[sbidoul]

Are we 100% sure this change works for svn and bzr too? Otherwise I'd do it for mercurial only.

[pradyunsg]

I figured we'd find out via CI, but doing it just for hg seems reasonable to me!

[sbidoul]

Thanks for doing this, @pradyunsg !

[pi4r0n]

@pradyunsg, I am a Windows 10 user, who just updated pip to 23.3. Before the upgrade, I was using -r requirements.txt to install modules.

I have noticed that you have changed it to -r=.... Unfortunately this does not work for me / or I am doing something wrong :(

C:\GIT\Pebble Automated Testing\Pebble Automated Testing>c:\python\python39\python.exe -m pip install --upgrade pip Collecting pip Downloading pip-23.3-py3-none-any.whl (2.1 MB) |████████████████████████████████| 2.1 MB ... Installing collected packages: pip Attempting uninstall: pip Found existing installation: pip 20.2.3 Uninstalling pip-20.2.3: Successfully uninstalled pip-20.2.3 Successfully installed pip-23.3

Now when I run the below command, it just fails. requirements.txt is there, just to be clear ;)

1. pip install -r=requirements.txt - ERROR: Could not open requirements file: [Errno 2] No such file or directory: '=requirements.txt'
2. pip install -r="requirements.txt" - ERROR: Could not open requirements file: [Errno 2] No such file or directory: '=requirements.txt'
3. pip install -r=FULL PATH\requirements.txt - ERROR: Could not open requirements file: [Errno 22] Invalid argument: '=FULL PATH\requirements.txt'
4. pip install -r="FULL PATH\requirements.txt" - ERROR: Could not open requirements file: [Errno 22] Invalid argument: '=FULL PATH\requirements.txt'

[pfmoore]

@pi4r0n This change is nothing to do with -r for requirements. Your previous approach of using -r requirements.txt should still be working just fine - if it's not, then that would be a different issue and you should raise a separate bug for it.