Cache supported tags in resolver factory #12755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really hope this patch get merged soon. ❤️ ❤️ ❤️ I am getting ~17% faster |
I've observed get_supported() consume up to 10% of the installation step when installing many packages. Each call can take 1-5ms (presumably only on Linux due to the large number of supported tags) and there is one call for every lookup in the cache. As all of these calls are made with no arguments, the tags can be trivially queried in advance during factory initialization.
ichard26
force-pushed
the
cache-supported-tags
branch
from
24e23bd to
47e82e2
Compare
|
Rebased on main and updated NEWS entry to more accurately reflect that this improves dependency resolution performance, not exclusively install performance. If CI stays 🍏, I'd like to see this merged. |
pfmoore
approved these changes
Jun 27, 2024
|
Nice improvement, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've observed get_supported() consume up to 10% of the installation step when installing many packages. Each call can take 1-5ms (presumably only on Linux due to the large number of supported tags) and there is one call for every lookup in the cache. As all of these calls are made with no arguments, the tags can be trivially queried in advance during factory initialization.
Example profile
python -m cProfile -o profile.pstats -m pip install --only-binary=:all: --no-index --ignore-installed --no-deps --find-links homeassistant/deps/ -r homeassistant/requirements.txt(from https://github.com/home-assistant/core/blob/2024.6.0/requirements.txt)get_supported()is left ofinstall_given_reqs()which is coloured green.Towards #12712.