Pause in prepare-release for updating the NEWS file
#12764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables making fixes to the NEWS file to fix issues prior to moving forward with the rest of the release process.
pradyunsg
added
the
skip news
uranusjr
approved these changes
Jun 12, 2024
webknjaz
approved these changes
Jun 12, 2024
| @@ -294,6 +294,11 @@ def prepare_release(session: nox.Session) -> None: | |||
|
|
|||
| session.log("# Generating NEWS") | |||
| release.generate_news(session, version) | |||
| if sys.stdin.isatty(): | |||
| input( | |||
| "Please review the NEWS file, make necessary edits, and stage them.\n" | |||
There was a problem hiding this comment.
How about
Suggested change
| "Please review the NEWS file, make necessary edits, and stage them.\n" | |
| "Please review the NEWS file, make necessary edits, and stage them (`git add NEWS.rst`).\n" |
?
Or the script could even run it unconditionally in this branch..
There was a problem hiding this comment.
Or the script could even run it unconditionally in this branch..
Let's do this in a follow up!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables making fixes to the NEWS file to fix issues prior to moving
forward with the rest of the release process.
x-ref #12509