-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ignoring sub-dependencies #12790
base: main
Are you sure you want to change the base?
Conversation
1a51f6b
to
a714fe5
Compare
-1 on implementing this for the leagcy resolver. We should not be making any changes to that code - it's destined for removal. Apart from that comment, I've not looked at this PR yet so I won't say anything more right now. |
@pfmoore, I only implemented it on the legacy resolver because it was a one-liner (other than formatting). It took a lot longer for me to add tests to the legacy resolver to check those changes than the change itself. Adding a check on the legacy resolver to fail to work with the new option (as has been done to other changes) would have taken the same complexity. But I'll gladly remove the change to the legacy resolver if that is the consensus. I'll await further comments on this PR before doing that. |
712ed55
to
30aef34
Compare
30aef34
to
ee807dd
Compare
Implement `--no-deps-for=pkg` to allow ignoring sub-dependencies of specific packages, as opposed to the global `--no-deps` flag. The flag is accepted on the command line and in requirements files. Implemented in both the new and the legacy resolvers.
ee807dd
to
1a49ce6
Compare
I've fixed the remaining CI errors. I'd appreciate a review and indication of next steps. |
Some general comments, intended as a review but they seem to fit better here than in the review screen.
To be honest, I think this PR might be premature, as the behaviour isn't fully defined yet. I'd be very uncomfortable if we simply said that the answers to the above questions was "whatever this PR does, or whatever is simplest to add to this PR". |
Implement
--no-deps-for=pkg
to allow ignoring sub-dependencies of specific packages, as opposed to the global--no-deps
flag.The flag is accepted on the command line and in requirements files.
Implemented in both the new and the legacy resolvers.
Also, implemented acceptance of the global
--no-deps
on the requirements file.Fixes: #9948