Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct usage of invalid file URL in test #12964

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Correct usage of invalid file URL in test #12964

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0896a5b
Correct usage of invalid file URL in test.
freakboy3742 Sep 12, 2024
4903645
Add changenote.
freakboy3742 Sep 12, 2024
5eaccb8
Also change the comment
uranusjr Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/12964.trivial.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
A valid, but non-existent URL used in a test case was corrected to be a valid URL.
2 changes: 1 addition & 1 deletion tests/functional/test_bad_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def test_filenotfound_error_message(script: Any) -> None:
# Test the error message returned when using a bad 'file:' URL.
# make pip to fail and get an error message
# by running "pip install -r file:nonexistent_file"
uranusjr marked this conversation as resolved.
Show resolved Hide resolved
proc = script.pip("install", "-r", "file:unexistent_file", expect_error=True)
proc = script.pip("install", "-r", "file:///unexistent_file", expect_error=True)
assert proc.returncode == 1
expect = (
"ERROR: 404 Client Error: FileNotFoundError for url: file:///unexistent_file"
Expand Down
Loading