Import self version check eagerly in install command to fix ACE #13085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pypa#13079. Signed-off-by: Caleb Brown <calebbrown@google.com>
Signed-off-by: Caleb Brown <calebbrown@google.com>
Signed-off-by: Caleb Brown <calebbrown@google.com>
ichard26
approved these changes
Nov 18, 2024
Signed-off-by: Caleb Brown <calebbrown@google.com>
|
Sure. Added. |
pradyunsg
approved these changes
Dec 6, 2024
notatallshaw
approved these changes
Dec 6, 2024
ichard26
approved these changes
Dec 7, 2024
ichard26
changed the title
|
And that's my first merge! A little scary if I'm being honest, but it does bring me back to the days where I used to maintain black :) |
|
And duh, I immediately spot a typo after I merge. It should really read ACE (arbitrary code execution), not RCE (remote code execution). 🙃 |
ichard26
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13079 by moving the import to the top of the module so that it is imported when
install.pyis imported.Preserve the comment as it is still relevant and add a note about preventing arbitrary code execution.