Remove gone_in for issue 11859 (deprecation of --build-option and --global-option) #13106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
changed the title
Open
ichard26
approved these changes
Dec 7, 2024
ichard26
force-pushed
the
rm-gone-in-for-11859-sbi
branch
from
0c2bfa3 to
60cba9c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setuptools has not stabilised their interface to pass build options, and forcing user to change from
--build-optionto two successive flavors of--config-settingsis not ideal.The setuptools tracking issue seems to be pypa/setuptools#3896, with some design discussion in pypa/setuptools#4083.
This does not mean that we will not want to remove these legacy options if setuptools does not move, but for now this is not a huge maintenance burden.