Remove unused news file GHA workflow and bot config #13107
Conversation
ichard26
added
skip news
|
Hmm, I wonder if the PSF Chronographer greyyed out status (from |
Yes, it does. When I temporarily update our branch protection rules to require the PSF Chronographer check instead of our own check, I can merge without complaint.
|
There was a problem hiding this comment.
@ichard26 You may not know this, but this app was specifically written for this pip repo originally.
I made it when @pradyunsg was looking to rewrite the legacy browntruck bot that used to be integrated in pip. It mostly reuses the same logic but also grew extra features over the years and is being used in a bunch of places now.
The gray status is what GitHub Checks API has as neutral. Branch protection basically treats anything that is not failed or pending as a success in that context.
The check is a lightweight PR diff analysis that is much cheaper than invoking Towncrier.
You can lurk into the source @ https://github.com/sanitizers/chronographer-github-app. I'm specifically targeting configuration though an in-repo file to avoid hardcoding anything and keep it flexible.
As for why there are two simultaneous checks in the repo — I suggested keeping them side-by-side to note any differences: #11848 (comment).
And now it's time to drop the GHA variant.
Hm… I was under impression that it was supposed to be required already. Perhaps mark it that permanently already? |
|
Let's do this! |
|
@pradyunsg I think it is expected that you click the actual approve button? |
|
@webknjaz thanks for the additional context! It's appreciated. |
|
To make it explicit: I changed our branch protection rules to require the PSF Chronographer status check (instead of our GHA news file workflow). |
The PSF Chronographer essentially replaces the news file check GHA workflow. It likes to send a bunch of redundant failure notifications (like when closing stale PRs).
I guess, towncrier does also check that the syntax of a news fragment is correct (although I haven't confirmed this). We could probably throw that in the docs GHA job.