Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve symlinks in local files #245

Merged
merged 1 commit into from
Oct 23, 2011
Merged

Conversation

ptone
Copy link
Contributor

@ptone ptone commented Apr 3, 2011

this allows --find-links to point to a local folder of symlinks to valid archives

the tar libraries choke when checking valid
filenames because they don't resolve symlinks

the tar libraries choke when checking valid
filenames because they don't resolve symlinks
@hltbra
Copy link
Contributor

hltbra commented Apr 3, 2011

Hi,

I do not understand very well the problem. Could you please show me a scenario where the problem happens?

@ptone
Copy link
Contributor Author

ptone commented Apr 4, 2011

The scenario where I hit this was in the first attempt to make use of the download cache as a --find-links target.

Because all the download cache is full of archives named as quoted URLs, they won't work. So I put together a quick script that just symlinked django-1.3.tar.gz in a folder to /http%2adblahblahblahdjango-1.3.tar.gz

pip will recognize the symlink as a valid archive, but when it goes to check the contents with the python tarfile lib, that library chokes on the symlink and pip will error out of the install. This change simply resolves the symlink before handing it off to the rest of the installation process.

@ptone
Copy link
Contributor Author

ptone commented Apr 4, 2011

Note I have since developed another way of using the download cache as a --find-link target, but figured this small fix was worth its own pull. I'll submit the more built in approach in its own pull shortly

carljm pushed a commit that referenced this pull request Oct 23, 2011
resolve symlinks in local files
@carljm carljm merged commit 47f1b2c into pypa:master Oct 23, 2011
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants