Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad entry point for completion #4014

Closed
wants to merge 2 commits into from
Closed

Fix bad entry point for completion #4014

wants to merge 2 commits into from

Conversation

toxinu
Copy link
Contributor

@toxinu toxinu commented Oct 17, 2016 •
edited by pradyunsg
Loading

According to #3997, completion template now use entry point used to run current command.

Edit: Fixes #3997

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 31, 2017
@pradyunsg
Copy link
Member

Hi @toxinu!

Could you rebase this PR on master? :)

@pradyunsg pradyunsg added S: awaiting response Waiting for a response/more information type: enhancement Improvements to functionality labels Aug 21, 2017
@toxinu toxinu force-pushed the fix-3997-entry-point-completion branch from 7272414 to de581b8 Compare August 22, 2017 16:08
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Aug 22, 2017
@toxinu
Copy link
Contributor Author

toxinu commented Aug 22, 2017

@pradyunsg Done! 😄

@pradyunsg
Copy link
Member

pradyunsg commented Aug 22, 2017 •
edited
Loading

Thanks! ^.^

This should probably be mentioned in the news file. Could you add a news fragment to this PR?

Edit: Details on that are available here.

pradyunsg
pradyunsg previously requested changes Aug 23, 2017
View reviewed changes
pip/commands/completion.py
@@ -37,7 +38,7 @@
set -lx PIP_AUTO_COMPLETE 1
string split \\ -- (eval $COMP_WORDS[1])
end
complete -fa "(__fish_complete_pip)" -c pip
complete -fa "(__fish_complete_pip)" -c %(pip_entry_point)s
Copy link
Member

@pradyunsg pradyunsg Aug 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put 2 %% symbols here (and above) so that it is possible to club together the formatting into one?

Basically, the delta at 84-86 would be reset and the base completion formatting would get a new key; meaning that the formatting of the arguments then only happens in one location which would probably look neater. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm.

@pradyunsg pradyunsg removed the S: awaiting response Waiting for a response/more information label Aug 23, 2017
@pradyunsg pradyunsg dismissed their stale review August 23, 2017 08:29

Okay - nvm. I should wake up properly.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Sep 1, 2017
@pradyunsg pradyunsg mentioned this pull request Oct 2, 2017
Merged
@toxinu toxinu deleted the fix-3997-entry-point-completion branch October 12, 2017 14:53
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
@pradyunsg pradyunsg removed the needs rebase or merge PR has conflicts with current master label Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip3 completion
4 participants
@toxinu @BrownTruck @pradyunsg @pypa-bot