-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move get_cache_path_for_link to WheelCache #4603
Conversation
pip/wheel.py
Outdated
@@ -780,8 +779,8 @@ def build(self, session, autobuilding=False): | |||
if autobuilding: | |||
python_tag = pep425tags.implementation_tag | |||
# NOTE: Should move out a method on the cache directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment can be removed.
What would the right way to implement #4562 with the new API be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment can be removed.
Nice spot. Thanks! :)
Here's a quick dump of what I'm thinking of doing now:
Once this is done, it'll be possible for @alex to use the base class (either by subclassing or by directly using it, depending on whether it's abstract) for the temporary cache. This is why I wrote #4562 (comment). edit: use name; not "you" |
Oh, and yes... anyone's inputs on this are more than welcome. ^.^ |
@alex I just gave this a bit more thought - I think you can just use |
Pinging @dstufft for a review. :) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.