Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move get_cache_path_for_link to WheelCache #4603

Merged
merged 2 commits into from
Jul 18, 2017

Conversation

pradyunsg
Copy link
Member

No description provided.

@pradyunsg pradyunsg added type: maintenance Related to Development and Maintenance Processes type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Jul 6, 2017
@pradyunsg pradyunsg self-assigned this Jul 6, 2017
@pradyunsg pradyunsg requested a review from a team July 6, 2017 09:57
pip/wheel.py Outdated
@@ -780,8 +779,8 @@ def build(self, session, autobuilding=False):
if autobuilding:
python_tag = pep425tags.implementation_tag
# NOTE: Should move out a method on the cache directly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can be removed.

What would the right way to implement #4562 with the new API be?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can be removed.

Nice spot. Thanks! :)

@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 6, 2017

What would the right way to implement #4562 with the new API be?

Here's a quick dump of what I'm thinking of doing now:

  • Bring in all cache-management code into one place
  • Introduce a new sdist cache; with egg-info {and in future dist-info}
  • Move out the common parts of the 2 caches into a common (abstract?) base class

Once this is done, it'll be possible for @alex to use the base class (either by subclassing or by directly using it, depending on whether it's abstract) for the temporary cache. This is why I wrote #4562 (comment).

edit: use name; not "you"

@pradyunsg
Copy link
Member Author

Here's a quick dump of what I'm thinking of doing now

Oh, and yes... anyone's inputs on this are more than welcome. ^.^

@pradyunsg
Copy link
Member Author

What would the right way to implement #4562 with the new API be?

@alex I just gave this a bit more thought - I think you can just use WheelCache directly using a temporary directory as it's cache_dir? Then these changes would leave you un-affected plus it would also be more clear in that it is using the abstraction it's supposed to... :)

@pradyunsg
Copy link
Member Author

Pinging @dstufft for a review. :)

@dstufft dstufft merged commit 133ec67 into pypa:master Jul 18, 2017
@pradyunsg pradyunsg deleted the refactor/cache-1 branch July 19, 2017 10:28
@pradyunsg pradyunsg removed their assignment Oct 5, 2017
@pradyunsg pradyunsg removed the type: maintenance Related to Development and Maintenance Processes label Nov 7, 2017
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants