Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issue #4507: don't warn when installing from a commit hash #4674

Merged
merged 7 commits into from
Oct 4, 2017
Merged

Address issue #4507: don't warn when installing from a commit hash #4674

merged 7 commits into from
Oct 4, 2017

Conversation

cjerdonek
Copy link
Member

This addresses issue #4507.

Note that I'm probably going to break this up into smaller PR's since the current PR simplifies / fixes some other things I noticed in the course of working on this issue.

This was referenced Aug 14, 2017
Closed
Closed
@cjerdonek cjerdonek force-pushed the issue-4507-git-install-hash-warning branch from 3947626 to 12272e2 Compare August 14, 2017 08:44
@pradyunsg
Copy link
Member

Is this still a WIP?

@cjerdonek
Copy link
Member Author

Yes. I want to break this up into smaller PR's (refactoring vs. behavior change as in the other PR). I'll remove the WIP prefix when it's ready. Thanks for asking!

@pradyunsg pradyunsg added type: enhancement Improvements to functionality C: vcs pip's interaction with version control systems like git, svn and bzr labels Aug 21, 2017
@cjerdonek cjerdonek force-pushed the issue-4507-git-install-hash-warning branch 2 times, most recently from 9cbd9db to c367c14 Compare August 23, 2017 06:28
@cjerdonek cjerdonek changed the title [WIP] Address issue #4507: don't warn when installing from a commit hash Address issue #4507: don't warn when installing from a commit hash Aug 23, 2017
@cjerdonek cjerdonek force-pushed the issue-4507-git-install-hash-warning branch 2 times, most recently from 7dec185 to 4fbca41 Compare August 23, 2017 07:42
@cjerdonek cjerdonek mentioned this pull request Aug 23, 2017
Merged
pradyunsg
pradyunsg approved these changes Aug 26, 2017
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :)

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Sep 1, 2017
@cjerdonek cjerdonek force-pushed the issue-4507-git-install-hash-warning branch from 4fbca41 to 6c24e66 Compare September 2, 2017 01:37
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Sep 2, 2017
@cjerdonek cjerdonek force-pushed the issue-4507-git-install-hash-warning branch from 6c24e66 to a83d12f Compare September 2, 2017 04:16
@cjerdonek
Copy link
Member Author

Rebased.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Oct 2, 2017
@cjerdonek cjerdonek force-pushed the issue-4507-git-install-hash-warning branch from a83d12f to e455b36 Compare October 3, 2017 03:13
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Oct 3, 2017
@cjerdonek
Copy link
Member Author

Rebased.

@xavfernandez xavfernandez merged commit c66ecc7 into pypa:master Oct 4, 2017
@xavfernandez
Copy link
Member

Thanks 👍

@cjerdonek
Copy link
Member Author

Thanks!

@alej0varas alej0varas mentioned this pull request Apr 1, 2018
Closed
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: vcs pip's interaction with version control systems like git, svn and bzr type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjerdonek @pradyunsg @BrownTruck @xavfernandez @pypa-bot