Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pkg_resource to setuptools v39.0.1 #5088

Closed
wants to merge 1 commit into from
Closed

Update pkg_resource to setuptools v39.0.1 #5088

wants to merge 1 commit into from

Conversation

wichert
Copy link

@wichert wichert commented Mar 19, 2018

This should address #5087, and includes the fix for pypa/setuptools#1282.

@pfmoore pfmoore self-assigned this Mar 19, 2018
@pfmoore pfmoore added this to the 10.0 milestone Mar 19, 2018
@pradyunsg
Copy link
Member

I think we should just do a pass over all the vendor packages a few days before the release. It'll be a neater IMO.

@pfmoore
Copy link
Member

pfmoore commented Mar 19, 2018

I'm planning on doing that, but cases like this, where we have issues to resolve, show the benefit of starting that process early. So thanks @wichert for picking up on this.

@pradyunsg
Copy link
Member

pradyunsg commented Mar 19, 2018

Fair enough. Thanks for this @wichert! :)

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Mar 24, 2018
@pfmoore
Copy link
Member

pfmoore commented Mar 24, 2018

Fixed via #5114

Thanks for the PR, @wichert. In the end it was easier for me to just update all the vendored libraries at once, so that's what I did.

@pfmoore pfmoore closed this Mar 24, 2018
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
@wichert wichert deleted the setuptools-v39.0.1 branch June 3, 2019 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants